JIT: Prezero memory for RefPosition and Interval #103707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4fe7a6.
Swap out the `jitstd::list` used for `RefPosition` and `Interval` to a new `PreZeroedList` that allocates memory in chunks and zeroes it all at once. Then get rid of all the `RefPosition` and `Interval` field zeroing done as part of their constructors.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
I don't think there is a way to do this in a well-defined way in C++ until C++23's |
|
TP improvements look like: Still not clear if the existing zeroing actually has any impact on performance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap out the
jitstd::listused forRefPositionandIntervalto anew
PreZeroedListthat allocates memory in chunks and zeroes it all atonce. Then get rid of all the
RefPositionandIntervalfield zeroingdone as part of their constructors.