Change fgMorphMultiOp to fgMorphHWIntrinsic #103732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
force-pushed
the
hwintrinsic-morph
branch
from
c22bf4d
to
aa736cf
Compare
tannergooding
force-pushed
the
hwintrinsic-morph
branch
from
aa736cf
to
60ee682
Compare
Open
3 tasks
EgorBo
reviewed
Jun 20, 2024
|
|
||
| if (vnStore != nullptr) | ||
| { | ||
| fgValueNumberTreeConst(vecCon); |
There was a problem hiding this comment.
nit: fgUpdateConstTreeValueNumber since it does vnStore != nullptr under the hood
There was a problem hiding this comment.
There's a few places doing this that can switch, I'll get them updated in a follow up PR.
EgorBo
reviewed
Jun 20, 2024
rzikm
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jun 24, 2024
* Remove a dead optimization from fgMorphMultiOp * Change fgMorphMultiOp to fgMorphHWIntrinsic * Move a couple of folding operations from `fgOptimizeHWIntrinsic` to `gtFoldExprHWIntrinsic` * Fix the query for if an intrinsic is commutative * Don't propagate vector constants unnecessarily
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple iterative cleanup. Namely it simplifies
fgMorphMultiOpto just befgMorphHWIntrinsicas that was the only user (and likely will be the only user for the foreseeable future).It additionally moves a couple of optimizations out of
fgOptimizeHWIntrinsicdown intofgFoldExprHWIntrinsicas they are simple folding operations removing nodes and/or producing constants. They are not more advanced transformations which would be producing new trees.