Keep this alive for classes with finalizers #103813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
commented
Jun 21, 2024
| if (resultflags.HasInstructionSet(InstructionSet_AVX512CD_VL) && !resultflags.HasInstructionSet(InstructionSet_AVX512CD)) | ||
| resultflags.RemoveInstructionSet(InstructionSet_AVX512CD_VL); | ||
| if (resultflags.HasInstructionSet(InstructionSet_AVX512CD_VL) && !resultflags.HasInstructionSet(InstructionSet_AVX512F_VL)) | ||
| resultflags.RemoveInstructionSet(InstructionSet_AVX512CD_VL); |
There was a problem hiding this comment.
I guess someone didn't use gen.bat and modified this file by hands
jkotas
reviewed
Jun 21, 2024
| if ((info.compCompHnd->getClassAttribs(info.compClassHnd) & CORINFO_FLG_HAS_FINALIZER) != 0) | ||
| { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Does this handle extending this lifetime for inlined methods?
There was a problem hiding this comment.
Good question, it does not. E.g. for synchronized methods we simply never inline them, which is too conservative to do in this case. So the fix has to be done in the importer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see how diffs look like, based on @jakobbotsch's suggestion #103522 (comment)