Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DAC return Module instead of PEAssembly for DacpModuleData::PEAssembly #103821

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

elinor-fung
Copy link
Member

Avoid exposing PEAssembly in the DAC APIs. Make DacpModuleData::PEAssembly and DacpGetModuleData::PEAssembly be the Module instead and update the GetPEFileName and GetPEFileBase to expect a module address.

Contributes to #99302. We want to avoid exposing PEAssembly at all in the cDAC.

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jun 22, 2024

Could you please also make a matching change to SOS to stop printing PEAssembly so that it does not cause confusion?

https://github.com/dotnet/diagnostics/blob/842c9603a97cf417814cf6c8d96e5c881025bf0e/src/SOS/Strike/strike.cpp#L3969

PEAssembly is not particular useful Module detail. It can be trivially fetched by regular windbg/lldb data inspection commands.

@elinor-fung elinor-fung merged commit 95964c1 into dotnet:main Jun 24, 2024
87 of 89 checks passed
@elinor-fung elinor-fung deleted the dac-hide-peassembly branch June 24, 2024 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants