Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V][LoongArch64] New passing info for floating-point structs #103945

Merged
merged 38 commits into from
Jul 26, 2024
Merged

[RISC-V][LoongArch64] New passing info for floating-point structs #103945

merged 38 commits into from
Jul 26, 2024

Commits on Jun 25, 2024

  1. Replace StructFloatFieldInfoFlags with FpStructInRegistersInfo which … 

    …carries also exact field sizes and offsets
    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    dcf2edb View commit details
    Browse the repository at this point in the history

  2. Replace StructFloatFieldInfoFlags with FpStruct::Flags in profiler

    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    48caa9c View commit details
    Browse the repository at this point in the history

  3. Remove FpStructInRegistersInfo::FromOldFlags()

    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    853bd99 View commit details
    Browse the repository at this point in the history

  4. Fix duplicating types in HandleInlineArray

    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0e80ccf View commit details
    Browse the repository at this point in the history

  5. Remove signedness from FpStruct::IntKind because most probably we won… 

    …'t need it
    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3d139ac View commit details
    Browse the repository at this point in the history

  6. Remove old StructFloatFieldInfoFlags calculating routine

    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    89cc148 View commit details
    Browse the repository at this point in the history

  7. Typo in TARGET_LOONGARCH64

    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c2984a2 View commit details
    Browse the repository at this point in the history

  8. Remove m_returnedFpFieldOffsets from ArgIterator

    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a229831 View commit details
    Browse the repository at this point in the history

  9. Add missing ENREGISTERED_PARAMTYPE_MAXSIZE condition to C# version of… 

    … FpStruct info calculation
    @tomeksowi
    tomeksowi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f2b38f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Rename RISCV64PassStructInRegister to match settled casing for RiscV … 

    …in class names
    @tomeksowi
    tomeksowi committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5481693 View commit details
    Browse the repository at this point in the history

  2. Update hardcoded flags for float and double in ArgIteratorTemplate::C… 

    …omputeReturnFlags()

This fixes JIT/HardwareIntrinsics/General/Vector* tests.
    @tomeksowi
    tomeksowi committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4250bf4 View commit details
    Browse the repository at this point in the history

  3. Fix build on other platforms

    @tomeksowi
    tomeksowi committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0f03a88 View commit details
    Browse the repository at this point in the history

  4. Update LoongArch to use FpStructInRegistersInfo

    @tomeksowi
    tomeksowi committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f485362 View commit details
    Browse the repository at this point in the history

  5. Remove unused old flag masks

    @tomeksowi
    tomeksowi committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9967e2e View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. LoongArch64 typo 

    Co-authored-by: Qiao Pengcheng <[email protected]>
    @tomeksowi @shushanhf
    tomeksowi and shushanhf authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6bc28d1 View commit details
    Browse the repository at this point in the history

  2. Missing FpStruct namespace 

    Co-authored-by: Qiao Pengcheng <[email protected]>
    @tomeksowi @shushanhf
    tomeksowi and shushanhf authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    33a6aee View commit details
    Browse the repository at this point in the history

  3. Missing FpStruct namespace 

    Co-authored-by: Qiao Pengcheng <[email protected]>
    @tomeksowi @shushanhf
    tomeksowi and shushanhf authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1e951bd View commit details
    Browse the repository at this point in the history

  4. Missing FpStruct namespace 

    Co-authored-by: Qiao Pengcheng <[email protected]>
    @tomeksowi @shushanhf
    tomeksowi and shushanhf authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fd49a25 View commit details
    Browse the repository at this point in the history

  5. Use FpStruct namespace everywhere in JIT

    @tomeksowi
    tomeksowi committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    214b94f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'main' into fp-struct-info

    @tomeksowi
    tomeksowi committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e34a68d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. JIT review

    @tomeksowi
    tomeksowi committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    08c6385 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge branch 'main' into fp-struct-info

    @tomeksowi
    tomeksowi committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f163a78 View commit details
    Browse the repository at this point in the history

  2. Update StructFloatFieldInfoFlags description

    @tomeksowi
    tomeksowi committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e23c0ab View commit details
    Browse the repository at this point in the history

  3. Revert to hitherto instruction set order as it's not the point of thi… 

    …s PR
    @tomeksowi
    tomeksowi committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ef5a6d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Unify get{LoongArch,RiscV}64PassFpStructInRegistersInfo JIT interfaces

    @tomeksowi
    tomeksowi committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    100eced View commit details
    Browse the repository at this point in the history

  2. Use JIT_TO_EE_TRANSITION instead of _LEAF because MethodTable::GetFpS… 

    …tructInRegistersInfo may throw
    @tomeksowi
    tomeksowi committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5c9e5ac View commit details
    Browse the repository at this point in the history

  3. Remove FpStruct::IntKind, we should have similar info in ClassLayout … 

    …in JIT
    @tomeksowi
    tomeksowi committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1d5ad91 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Change JIT interface to return a struct similar to CORINFO_SWIFT_LOWE… 

    …RING to facilitate code unification in the future
    @tomeksowi
    tomeksowi committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    7b1587b View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Change JIT to use new Swift-like getFpStructLowering

    @tomeksowi
    tomeksowi committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e37e984 View commit details
    Browse the repository at this point in the history

  2. Cache CORINFO_FPSTRUCT_LOWERING

    @tomeksowi
    tomeksowi committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c7c88e0 View commit details
    Browse the repository at this point in the history

  3. Update LoongArch classifier to use CORINFO_FPSTRUCT_LOWERING

    @tomeksowi
    tomeksowi committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5c478d7 View commit details
    Browse the repository at this point in the history

  4. Update StructFloatInfoFlags doc comment on C#

    @tomeksowi
    tomeksowi committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1f16783 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Move StructFloatFieldInfoFlags and FpStructInRegistersInfo out of the… 

    … JIT interface
    @tomeksowi
    tomeksowi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f064eb6 View commit details
    Browse the repository at this point in the history

  2. Merge LoongArch and RISC-V AOT calculation of FpStructInRegistersInfo… 

    … because they were identical. Move it to Common\Internal/Runtime because it's no longer exposed in JIT interface.
    @tomeksowi
    tomeksowi committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d4be92c View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Don't zero-initialize CORINFO_FPSTRUCT_LOWERING

    @tomeksowi
    tomeksowi committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    823df8b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'main' into fp-struct-info

    @tomeksowi
    tomeksowi committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c209a55 View commit details
    Browse the repository at this point in the history

  2. Add note for CORINFO_FPSTRUCT_LOWERING::loweredElements type

    @tomeksowi
    tomeksowi committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8ddd349 View commit details
    Browse the repository at this point in the history

  3. object is lowercase

    @tomeksowi
    tomeksowi committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9dc5ed5 View commit details
    Browse the repository at this point in the history