Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default #104202

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default #104202

merged 5 commits into from
Jul 2, 2024

Conversation

stephentoub
Copy link
Member

Fixes #102906

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 30, 2024
@stephentoub stephentoub force-pushed the equalitycomparerdefaultalternate branch 2 times, most recently from 69a192b to b627e2c Compare June 30, 2024 03:32
@build-analysis build-analysis bot mentioned this pull request Jun 30, 2024
Open
@stephentoub stephentoub force-pushed the equalitycomparerdefaultalternate branch from 894ce80 to a6e4488 Compare July 1, 2024 02:49
@jkotas jkotas added area-System.Collections and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 1, 2024
This was referenced Jul 1, 2024
Open
Open
Closed
@stephentoub stephentoub marked this pull request as ready for review July 1, 2024 13:56
@stephentoub stephentoub force-pushed the equalitycomparerdefaultalternate branch from 5b1ec8f to d13131e Compare July 1, 2024 13:56
eiriktsarpalis
eiriktsarpalis reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing lots of build errors, but they appear to be infra related?

@build-analysis build-analysis bot mentioned this pull request Jul 1, 2024
Open
@stephentoub stephentoub mentioned this pull request Jul 1, 2024
Merged
tannergooding
tannergooding approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed side changes LGTM.

@stephentoub stephentoub closed this Jul 1, 2024
@stephentoub stephentoub reopened this Jul 1, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 1, 2024
Closed
@jkotas
Copy link
Member

jkotas commented Jul 1, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jkotas
jkotas approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the naot test run passed with no failures related to this change)

@build-analysis build-analysis bot mentioned this pull request Jul 1, 2024
Closed
@jkotas jkotas mentioned this pull request Jul 1, 2024
Closed
@stephentoub stephentoub mentioned this pull request Jul 2, 2024
Open
@stephentoub stephentoub merged commit aa280ad into dotnet:main Jul 2, 2024
159 of 170 checks passed
@stephentoub stephentoub deleted the equalitycomparerdefaultalternate branch July 2, 2024 01:39
@jkotas jkotas mentioned this pull request Jul 3, 2024
Closed
@matouskozak matouskozak mentioned this pull request Jul 9, 2024
Closed
@LoopedBard3
Copy link
Member

Improvements:
Linux x64: dotnet/perf-autofiling-issues#37870
Windows x64: dotnet/perf-autofiling-issues#37858, dotnet/perf-autofiling-issues#37822

@lewing lewing mentioned this pull request Jul 9, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalPetryka MichalPetryka MichalPetryka left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@jkotas jkotas jkotas approved these changes

@tannergooding tannergooding tannergooding approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@stephentoub stephentoub

Labels
area-System.Collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default
6 participants
@stephentoub @jkotas @LoopedBard3 @eiriktsarpalis @tannergooding @MichalPetryka