Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Sve.Scatter() #104555

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Add support for Sve.Scatter() #104555

merged 4 commits into from
Jul 10, 2024

Conversation

SwapnilGaikwad
Copy link
Contributor

Contribute towards #99957.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 8, 2024
@SwapnilGaikwad
Copy link
Contributor Author

@a74nh @kunalspathak @dotnet/arm64-contrib @arch-arm64-sve

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@SwapnilGaikwad
Copy link
Contributor Author

All tests are passing 
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_bases_double_ulong() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_bases_long_ulong() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_bases_ulong_ulong() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_double_long() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_double_ulong() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_int_int() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_int_uint() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_long_long() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_long_ulong() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_float_int() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_float_uint() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_uint_int() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_uint_uint() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_ulong_long() : 9
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve._Sve.Program.Sve_Scatter_indices_ulong_ulong() : 9
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

This was referenced Jul 8, 2024
Open
Open
Open
Open
Closed
Closed
@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Jul 9, 2024
kunalspathak
kunalspathak reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but will wait for answers to some of my questions.

src/coreclr/jit/hwintrinsiccodegenarm64.cpp Show resolved Hide resolved
src/coreclr/jit/hwintrinsic.cpp Outdated Show resolved Hide resolved
@kunalspathak kunalspathak mentioned this pull request Jul 9, 2024
Closed
@SwapnilGaikwad SwapnilGaikwad marked this pull request as ready for review July 9, 2024 17:27
This was referenced Jul 9, 2024
Closed
Closed
kunalspathak
kunalspathak approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kunalspathak
Copy link
Member

/ba-g one failing test is a timeout issue

@kunalspathak kunalspathak merged commit c52fd37 into dotnet:main Jul 10, 2024
140 of 167 checks passed
@SwapnilGaikwad SwapnilGaikwad deleted the github-sve-scatter branch July 10, 2024 09:16
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@matouskozak
Revert "Add support for Sve.Scatter() (dotnet#104555)"
9828757 
This reverts commit c52fd37.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwapnilGaikwad @kunalspathak