Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Link native shared libraries with 16k page alignment #104577

Merged
merged 6 commits into from
Jul 16, 2024
Merged

[Android] Link native shared libraries with 16k page alignment #104577

merged 6 commits into from
Jul 16, 2024

Commits on Jul 16, 2024

  1. [Android] Link native shared libraries with 16k page alignment 

    Fixes: dotnet#103360
Context: https://developer.android.com/guide/practices/page-sizes
Context: https://github.com/android/ndk/wiki/Changelog-r27#announcements

Sometime next year Google will start requiring that all the `.so`
libraries included in applications submitted to the Play Store to be
aligned to 16k page boundary (as opposed to the current one of 4k).

Make changes to cmake scripts used to build both the BCL native
libraries and the MonoVM so that the resulting shared libraries have the
correct alignment.
    @grendello
    grendello committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    11b6383 View commit details
    Browse the repository at this point in the history

  2. remove debug stuff

    @grendello
    grendello committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    936f458 View commit details
    Browse the repository at this point in the history

  3. Address feedback

    @grendello
    grendello committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e8baeed View commit details
    Browse the repository at this point in the history

  4. Add support for 16k pages in library builder

    @grendello
    grendello committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9a27b17 View commit details
    Browse the repository at this point in the history

  5. Implement requested changes

    @grendello
    grendello committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9f47f63 View commit details
    Browse the repository at this point in the history

  6. Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ… 

    …e.Unix.targets

Co-authored-by: Michal Strehovský <[email protected]>
    @grendello @MichalStrehovsky
    grendello and MichalStrehovsky committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    675d549 View commit details
    Browse the repository at this point in the history