Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NET 8.0 target to Microsoft.Bcl.Memory package #104648

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Add NET 8.0 target to Microsoft.Bcl.Memory package #104648

merged 4 commits into from
Jul 11, 2024

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Jul 9, 2024

  • #if-def-ed some new APIs that newly added in .NET 9.0 like CompExactlyDependsOn attribute
  • Added .NET 8.0 copies for internal APIs that exist in 9.0 but not in 8.0 like: Ascii.VectorContainsNonAsciiChar, Ascii.ExtractAsciiVector, Vector128.SuffleUnsafe.
  • Some APIs in ARM vectorization path not exist in 8.0, so made the ARM code path only for .NET 9

Fixes #104185

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 9, 2024
This was referenced Jul 10, 2024
Open
Open
Open
@buyaa-n buyaa-n added area-System.Buffers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 10, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

This was referenced Jul 10, 2024
Open
Closed
Open
Closed
@buyaa-n buyaa-n merged commit 4dd997d into dotnet:main Jul 11, 2024
133 of 146 checks passed
@buyaa-n buyaa-n deleted the net8target branch July 11, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

@ericstj ericstj Awaiting requested review from ericstj

Assignees

@buyaa-n buyaa-n

Labels
area-System.Buffers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NET 8.0 target to Microsoft.Bcl.Memory package
3 participants
@buyaa-n @ViktorHofer @tarekgh