Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tests that use a flaky FSW in Windows #104988

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Disable tests that use a flaky FSW in Windows #104988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public void FileSystemWatcher_Directory_Changed_SymLink()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_Changed_SynchronizingObject()
{
string dir = CreateTestDirectory(TestDirectory, "dir");
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public void FileSystemWatcher_Directory_PathNotExists()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_Create()
{
using (var watcher = new FileSystemWatcher(TestDirectory))
Expand All @@ -46,6 +47,7 @@ public void FileSystemWatcher_Directory_Create()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_Create_InNestedDirectory()
{
string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");
Expand Down Expand Up @@ -98,6 +100,7 @@ public void FileSystemWatcher_Directory_Create_SymLink()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_Create_SynchronizingObject()
{
using (var watcher = new FileSystemWatcher(TestDirectory))
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public void FileSystemWatcher_Directory_Delete_DeepDirectoryStructure()
}

[ConditionalFact(typeof(MountHelper), nameof(MountHelper.CanCreateSymbolicLinks))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_Delete_SymLink()
{
string dir = CreateTestDirectory(TestDirectory, "dir");
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public void Unix_Directory_Move_To_Different_Watched_Directory()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void Directory_Move_From_Unwatched_To_Watched()
{
DirectoryMove_FromUnwatchedToWatched(WatcherChangeTypes.Created);
Expand All @@ -85,6 +86,7 @@ public void Directory_Move_From_Unwatched_To_Watched()
[Theory]
[InlineData(false)]
[InlineData(true)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void Directory_Move_In_Nested_Directory(bool includeSubdirectories)
{
DirectoryMove_NestedDirectory(includeSubdirectories ? WatcherChangeTypes.Renamed : 0, includeSubdirectories);
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ private static partial uint SetSecurityInfoByHandle( string name, uint objectTyp

[Theory]
[MemberData(nameof(FilterTypes))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_NotifyFilter_Attributes(NotifyFilters filter)
{
FileSystemWatcherTest.Execute(() =>
Expand Down Expand Up @@ -165,6 +166,7 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteTime_TwoFilters(No
[Theory]
[MemberData(nameof(FilterTypes))]
[PlatformSpecific(TestPlatforms.Windows)] // Uses P/Invokes to set security info
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_NotifyFilter_Security(NotifyFilters filter)
{
string dir = CreateTestDirectory(TestDirectory, "dir");
Expand Down Expand Up @@ -222,6 +224,7 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteAndFileName()
/// after each other.
/// </summary>
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_NotifyFilter_ModifyAndCreate()
{
string dir = CreateTestDirectory(TestDirectory, "dir");
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace System.IO.Tests
public class File_Changed_Tests : FileSystemWatcherTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_File_Changed_LastWrite()
{
string file = CreateTestFile(TestDirectory, "file");
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public void FileSystemWatcher_File_Create_ForcedRestart()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_File_Create_InNestedDirectory()
{
string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace System.IO.Tests
public class File_Delete_Tests : FileSystemWatcherTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_File_Delete()
{
using (var watcher = new FileSystemWatcher(TestDirectory))
Expand All @@ -27,6 +28,7 @@ public void FileSystemWatcher_File_Delete()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_File_Delete_ForcedRestart()
{
using (var watcher = new FileSystemWatcher(TestDirectory))
Expand All @@ -47,6 +49,7 @@ public void FileSystemWatcher_File_Delete_ForcedRestart()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_File_Delete_InNestedDirectory()
{
string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public class File_Move_Tests : FileSystemWatcherTest
{
[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Expected WatcherChangeTypes are different based on OS
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void Windows_File_Move_To_Same_Directory()
{
FileMove_SameDirectory(WatcherChangeTypes.Renamed);
Expand Down Expand Up @@ -126,6 +127,7 @@ public void Unix_File_Move_With_Set_NotifyFilter()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void File_Move_SynchronizingObject()
{
string dir = CreateTestDirectory(TestDirectory, "dir");
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ public void FileSystemWatcher_File_NotifyFilter_LastWriteTime(NotifyFilters filt

[Theory]
[MemberData(nameof(FilterTypes))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_File_NotifyFilter_Size(NotifyFilters filter)
{
string file = CreateTestFile(TestDirectory, "file");
Expand Down Expand Up @@ -193,6 +194,7 @@ public void FileSystemWatcher_File_NotifyFilter_Size_TwoFilters(NotifyFilters fi
[Theory]
[MemberData(nameof(FilterTypes))]
[PlatformSpecific(TestPlatforms.Windows)] // Uses P/Invokes to set security info
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_File_NotifyFilter_Security(NotifyFilters filter)
{
string file = CreateTestFile(TestDirectory, "file");
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public void FileSystemWatcher_InternalBufferSize(bool setToHigherCapacity)
[Fact]
[PlatformSpecific(TestPlatforms.Windows)]
[OuterLoop("A little slow")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_InternalBufferSize_SynchronizingObject()
{
ManualResetEvent unblockHandler = new ManualResetEvent(false);
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public void FileSystemWatcher_DirectorySymbolicLink_TargetsSelf_Fails()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create()
{
// Arrange
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ public void FileSystemWatcher_IncludeSubdirectories()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_InternalBufferSize()
{
FileSystemWatcher watcher = new FileSystemWatcher();
Expand Down Expand Up @@ -567,6 +568,7 @@ public void FileSystemWatcher_StopCalledOnBackgroundThreadDoesNotDeadlock()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_WatchingAliasedFolderResolvesToRealPathWhenWatching()
{
string dir = CreateTestDirectory(TestDirectory, "dir");
Expand Down Expand Up @@ -1001,6 +1003,7 @@ public void FileSystemWatcher_Directory_Create_Filter_Ctor()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
public void FileSystemWatcher_Directory_Delete_MultipleFilters()
{
using var tempDir = new TempDirectory();
Expand Down
Loading