[cdac] Implement GetObjectStringData #105061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
elinor-fung
commented
Jul 18, 2024
| string IObject.GetStringValue(TargetPointer address) | ||
| { | ||
| TargetPointer mt = GetMethodTableAddress(address); | ||
| if (mt != _stringMethodTable) |
There was a problem hiding this comment.
DAC also does DacValidateMethodTable (cDAC equivalent would be RuntimeTypeSystem.GetTypeHandle), but it seemed unnecessary since we check that it is the known string method table.
elinor-fung
requested review from
lambdageek,
davidwrighton and
AaronRobinsonMSFT
25 tasks
This was referenced Jul 18, 2024
elinor-fung
commented
Jul 18, 2024
Co-authored-by: Jeremy Koritzinsky <[email protected]>
lambdageek
approved these changes
Jul 18, 2024
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringandObjectin data descriptorObjectcontract for getting information about known managed objectsISOSDacInterface::GetObjectStringDataContributes to #99302