Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-staging] Disable W^X in Rosetta emulated x64 containers on macOS #105117

Merged
merged 4 commits into from
Aug 13, 2024
Merged

[release/8.0-staging] Disable W^X in Rosetta emulated x64 containers on macOS #105117

merged 4 commits into from
Aug 13, 2024

Commits on Jul 18, 2024

  1. Disable W^X on x64 in rosetta based container 

    The docker on macOS Arm64 uses Rosetta to run x64 containers. That
has an effect on the double mapping. The Rosetta is unable to detect
when an already executed code page is modified. So we cannot use double
mapping on those containers. To detect that case, this change adds check
that verifies that the double mapping works even when the code is
modified.

Close #102226
    @janvorli
    janvorli authored and github-actions committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a02bf86 View commit details
    Browse the repository at this point in the history

  2. Rework based on PR feedback

    @janvorli
    janvorli authored and github-actions committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    12d5741 View commit details
    Browse the repository at this point in the history

  3. Check only for Rosetta

    @janvorli
    janvorli authored and github-actions committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ceb1349 View commit details
    Browse the repository at this point in the history

  4. Enable the rosetta check for x86 too 

    This will help WINE running 32 bit code under rosetta emulation on
macOS.
    @janvorli
    janvorli authored and github-actions committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ba079e9 View commit details
    Browse the repository at this point in the history