Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DefaultMaximumErrorResponseLength to KB from Byte #105396

Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ public override Stream GetResponseStream()
return contentStream;
}

return new TruncatedReadStream(contentStream, maxErrorResponseLength);
return new TruncatedReadStream(contentStream, maxErrorResponseLength * 1024);
liveans marked this conversation as resolved.
Show resolved Hide resolved
}

return Stream.Null;
Expand Down Expand Up @@ -381,7 +381,7 @@ private void CheckDisposed()

private static string GetHeaderValueAsString(IEnumerable<string> values) => string.Join(", ", values);

internal sealed class TruncatedReadStream(Stream innerStream, int maxSize) : Stream
internal sealed class TruncatedReadStream(Stream innerStream, long maxSize) : Stream
{
public override bool CanRead => true;
public override bool CanSeek => false;
Expand All @@ -399,7 +399,7 @@ public override int Read(byte[] buffer, int offset, int count)

public override int Read(Span<byte> buffer)
{
int readBytes = innerStream.Read(buffer.Slice(0, Math.Min(buffer.Length, maxSize)));
int readBytes = innerStream.Read(buffer.Slice(0, (int)Math.Min(buffer.Length, maxSize)));
maxSize -= readBytes;
liveans marked this conversation as resolved.
Show resolved Hide resolved
return readBytes;
}
Expand All @@ -411,7 +411,7 @@ public override Task<int> ReadAsync(byte[] buffer, int offset, int count, Cancel

public override async ValueTask<int> ReadAsync(Memory<byte> buffer, CancellationToken cancellationToken = default)
{
int readBytes = await innerStream.ReadAsync(buffer.Slice(0, Math.Min(buffer.Length, maxSize)), cancellationToken)
int readBytes = await innerStream.ReadAsync(buffer.Slice(0, (int)Math.Min(buffer.Length, maxSize)), cancellationToken)
.ConfigureAwait(false);
maxSize -= readBytes;
return readBytes;
Expand Down
31 changes: 18 additions & 13 deletions src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2318,33 +2318,38 @@ await server.AcceptConnectionAsync(
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public async Task SendHttpRequest_WhenDefaultMaximumErrorResponseLengthSet_Success()
{
await RemoteExecutor.Invoke(async (async) =>
await RemoteExecutor.Invoke(async isAsync =>
{
TaskCompletionSource tcs = new TaskCompletionSource();
await LoopbackServer.CreateClientAndServerAsync(
async (uri) =>
async uri =>
{
HttpWebRequest request = WebRequest.CreateHttp(uri);
HttpWebRequest.DefaultMaximumErrorResponseLength = 5;
var exception =
await Assert.ThrowsAsync<WebException>(() => bool.Parse(async) ? request.GetResponseAsync() : Task.Run(() => request.GetResponse()));
HttpWebRequest.DefaultMaximumErrorResponseLength = 1; // 1 KB
liveans marked this conversation as resolved.
Show resolved Hide resolved
WebException exception =
await Assert.ThrowsAsync<WebException>(() => bool.Parse(isAsync) ? request.GetResponseAsync() : Task.Run(() => request.GetResponse()));
tcs.SetResult();
Assert.NotNull(exception.Response);
using (var responseStream = exception.Response.GetResponseStream())
using (Stream responseStream = exception.Response.GetResponseStream())
{
var buffer = new byte[10];
int readLen = responseStream.Read(buffer, 0, buffer.Length);
Assert.Equal(5, readLen);
Assert.Equal(new string('a', 5), Encoding.UTF8.GetString(buffer[0..readLen]));
Assert.Equal(0, responseStream.Read(buffer));
byte[] buffer = new byte[10 * 1024];
int totalReadLen = 0;
int readLen = 0;
while ((readLen = responseStream.Read(buffer, readLen, buffer.Length - readLen)) > 0)
{
totalReadLen += readLen;
}

Assert.Equal(1024, totalReadLen);
Assert.Equal(new string('a', 1024), Encoding.UTF8.GetString(buffer[0..totalReadLen]));
}
},
async (server) =>
async server =>
{
await server.AcceptConnectionAsync(
async connection =>
{
await connection.SendResponseAsync(statusCode: HttpStatusCode.BadRequest, content: new string('a', 10));
await connection.SendResponseAsync(statusCode: HttpStatusCode.BadRequest, content: new string('a', 10 * 1024));
await tcs.Task;
});
});
Expand Down
Loading