-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SunOS process and thread support #105403
base: main
Are you sure you want to change the base?
SunOS process and thread support #105403
Conversation
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
Lets drop the changes which are already submitted in other PRs. |
src/libraries/Common/src/Interop/SunOS/procfs/Interop.ProcFsStat.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessThread.SunOS.cs
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.BSD.cs
Outdated
Show resolved
Hide resolved
Good start! I've left initial feedback, which I anticipate the maintainers will point out. :) |
Thanks. I had not yet seen #105207 when I opened this. I think @AustinWise and I should figure out how to get the prerequisite fixes shown there (and here) all integrated, and then I'll rebase the last parts of this onto that. |
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.SunOS.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.SunOS.cs
Outdated
Show resolved
Hide resolved
I'd love to, but I do not see a way to do "stacked" PRs, where one PR targets the branch of another PR. |
Create a local branch |
src/libraries/Common/src/Interop/SunOS/procfs/Interop.ProcFs.Definitions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.SunOS.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessThread.SunOS.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C# for reading from procfs and enumerating threads/processes looks good to me.
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.SunOS.cs
Outdated
Show resolved
Hide resolved
Rebased and squashed |
Looks good to me. Thanks for this @gwr! This is one major step to complete the shared framework on illumos-x64 and enabling msbuild/sdk. 👍 @adamsitnik, @jkotas, PTAL. |
@gwr fyi, we are not required to rebase for every commit merging in main branch. It's rather a busy repo so GH will likely always show you that your branch is behind by X number of commits. The maintainers can do the rebase if deemed necessary. |
Read binary psinfo for System.Diagnostic.Process on SunOS Thanks for initial prototype help from: Austin Wise <[email protected]> Add Try prefix to SunOS Interop functions Get rid of unsafe for procfs get methods
Updated to fix a comment (nit) |
OK, thanks. Won't do it too often. |
Here too; Can anyone tell me what to do about the runtime checks that reported failure? |
Don't worry about them. They are not related to your change. |
nudge 2 |
nudge 3 |
Please excuse me for lack of response, I am busy fixing some last minute bugs for .NET 9. I should be less busy after the RC2 branch snap next week and I hope to be able to review it then. |
Read binary psinfo for System.Diagnostic.Process on SunOS (Solaris or illumos).
No failures in System.Diagnostic.Process.Tests (but lots of skip)
BTW, I tried rebasing on main from Mon. this week and ran into problems downloading stuff.
Not sure why, but it didn't seem to have anything to do with my changes.