-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZLib, Brotli compression options #105430
Conversation
Note regarding the
|
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Show resolved
Hide resolved
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
e3ed2b6
to
f981aac
Compare
f981aac
to
ecd4907
Compare
...ibraries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliStream.Compress.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateZLib/DeflateStream.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression.Brotli/tests/CompressionStreamUnitTests.Brotli.cs
Outdated
Show resolved
Hide resolved
{ | ||
Debug.Assert(windowBits >= minWindowBits && windowBits <= maxWindowBits); | ||
|
||
int memLevel = options.CompressionLevel == 0 ? ZLibNative.Deflate_NoCompressionMemLevel : ZLibNative.Deflate_DefaultMemLevel; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has anyone requested being able to configure the memory level? I assume this is something we would consider adding as another property on the options in the future if it was needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real request, yes it can be added when needed
src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateZLib/Deflater.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs
Outdated
Show resolved
Hide resolved
f115adf
to
e206031
Compare
…at failing in some CI legs
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Deflate.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.Gzip.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/tests/CompressionStreamUnitTests.ZLib.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I left a few comments for you to consider.
...aries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliCompressionOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
...aries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliCompressionOptions.cs
Outdated
Show resolved
Hide resolved
...ibraries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliStream.Compress.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateZLib/DeflateStream.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression/tests/ZLibCompressionOptionsUnitTests.cs
Show resolved
Hide resolved
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Sánchez López <[email protected]>
d0335f8
to
35b3f9f
Compare
…ZLibCompressionOptions.cs Co-authored-by: Carlos Sánchez López <[email protected]>
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibCompressionOptions.cs
Outdated
Show resolved
Hide resolved
…ZLibCompressionOptions.cs
what about dictionary size |
Approved API shape:
Fixes #42820