-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alpine version for libraries pipeline #105553
Conversation
note that the standard test CI will not test the 3.20 addition, it only runs for extra-platforms pipeline ( - ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: and - ${{ if and(eq(parameters.platform, 'linux_musl_arm64'), or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true))) }}: |
Thanks for the note @CarnaViire, I'm aware of it, but I tried to keep 1 version style for normal runs as we used to have before here. |
There are (at least were) "hacks" to check stuff like this without having to run extra-platforms which is super expensive; let me find a PR where I was in a similar situation |
I'm not saying you need to change anything (in the "final form" of the PR), I just want the distro to be verified before the PR is merged (and potentially become a noise in outerloops and extra-platforms) |
This reverts commit 109aeee.
Tests are passing on all 3 alpine versions. Reverted change back and ready to review. /cc @CarnaViire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to backport this to 8.0 and/or 6.0?
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
I'm not sure about the infra perspective here, but we don't need this PR in 8.0/6.0 for now, as far as I know. /cc @ManickaP |
Removing EOL Alpine 3.16 from pipeline (image already deleted: dotnet/dotnet-buildtools-prereqs-docker#1078)
Adding Alpine 3.17 for normal runs and 3.20 for extra-platforms to pipeline
/cc @ManickaP