Fix shutdown with multiple unhandled HW exceptions #105578
Merged
+68
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple threads crash with hardware unhandled exceptions at the same time, the fact that we were uninstalling async signal handlers at process exit caused crashes when some thread reached the signal handler after .NET handler was removed. This change fixes it by not restoring the signal handlers during process exit. It actually stops restoring any signal handlers except for SIGABRT that has to be restored to actually enable the process exit with abort(). Close dotnet#46175
jkotas
approved these changes
Jul 26, 2024
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Known failures (#105441) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple threads crash with hardware unhandled exceptions at the same time, the fact that we were uninstalling async signal handlers at process exit caused crashes when some thread reached the signal handler after .NET handler was removed.
This change fixes it by not restoring the signal handlers during process exit. It actually stops restoring any signal handlers except for SIGABRT that has to be restored to actually enable the process exit with abort().
Close #46175