Ensure that negation of floating-point values is correctly handled #105629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
reviewed
Jul 29, 2024
| @@ -415,18 +430,7 @@ inline double EvaluateUnaryScalarSpecialized<double>(genTreeOps oper, double arg | |||
| template <typename TBase> | |||
| TBase EvaluateUnaryScalar(genTreeOps oper, TBase arg0) | |||
There was a problem hiding this comment.
nit: is EvaluateUnaryScalar method needed then? callers can call EvaluateUnaryScalarSpecialized directly
There was a problem hiding this comment.
It might not be needed, but it's consistent with the setup of other APIs.
If we were to change this, I'd probably make it EvaluateUnaryScalar and just specialize that directly instead. That way there isn't two differently named entry points for Unary vs Binary vs ...
EgorBo
approved these changes
Jul 29, 2024
This was referenced Jul 29, 2024
tannergooding
force-pushed
the
fix-105627
branch
from
c21e11e
to
d4a0101
Compare
This was referenced Jul 29, 2024
|
FYI @tannergooding about this regression: #106144 (also mentioned above) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #105627