JIT: Encode SIMD base type in VN for all HW intrinsics

[jakobbotsch]

This changes the VN funcs for all HW intrinsic functions to always have an extra parameter for the SIMD base type. Before this change it was based on the instruction list, however that is not always the right thing (e.g. #105721 is a bug because of that). We also kept it as part of the HW intrinsic table, but that requires manual maintenance and is easy to get wrong. Always encoding the type is much more simple and the diffs do not look too bad.

In .NET 10 we can decide if we want to opt some intrinsics into not being differentiated based on the SIMD base type. The easiest thing might be to always map those to have the same base SIMD type (e.g. CORINFO_TYPE_BYTE) so that we don't end up with differences in arities for some VN functions that are hard to reason about.

Fix #105721

[jakobbotsch]

cc @dotnet/jit-contrib PTAL @tannergooding

I went with your suggestion to just encode the SIMD base type for all HW intrinsics, and removed all the references to the old stuff. The diffs (from the run before I pushed the test) are miniscule so definitely seems like the right direction to go here.

[tannergooding]

The diffs (from the run before I pushed the test) are miniscule so definitely seems like the right direction to go here.

👍, mostly looks to be around bitwise operations (and, or, xor, not, ternlog, etc). Users have the ability to manually workaround for these if its important in .NET 9 and mixing types to that degree is relatively rare, so I wouldn't expect most code to be pessimized by this. Should be easy to improve the select cases in .NET 10.

[tannergooding]

This comment is notably out of date, we produce GT_CNS_VEC for cases like AllBitsSet now. Off the top of my head, other zero arg intrinsics should also be getting converted to constant nodes and I'm not sure any cases actually exist that can hit this anymore.

Should be safe to leave in for .NET 9, but might be something we can cleanup early in .NET 10

[a74nh]

We're getting failures on all the SVE tests. We suspect it's this PR, but just confirming...

  Starting test: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareInt  rinsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll GatherVectorFirstFaulting                                                                                                                                                                                                                                   
  ===================Running default===================                                                                                                                                                                                                                                                                       
  ------------------- {} -------------------                                                                                                                                                                                                                                                                                  
  Errors:                                                                                                                                                                                                                                                                                                                     
                                                                                                                                                                                                                                                                                                                              
  Assert failure(PID 3341648 [0x0032fd50], Thread: 3341648 [0x32fd50]): Assertion failed 'vnStore->VNFuncArity(func) == 1' in 'JIT.HardwareIntrinsics.Arm._Sve.SveGatherVectorVectorBasesTest__Sve_GatherVectorFirstFaulting_Bases_double_ulong:RunBasicScenario_UnsafeRead():this' during 'Do value numbering' (IL size 110;   hash 0x04f13b09; FullOpts)                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                              
      File: /home/mikabl01/dotnet/runtime/src/coreclr/jit/valuenum.cpp:12998                                                                                                                                                                                                                                                  
      Image: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun   

[jakobbotsch]

We're getting failures on all the SVE tests. We suspect it's this PR, but just confirming...

  Starting test: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareInt  rinsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll GatherVectorFirstFaulting                                                                                                                                                                                                                                   
  ===================Running default===================                                                                                                                                                                                                                                                                       
  ------------------- {} -------------------                                                                                                                                                                                                                                                                                  
  Errors:                                                                                                                                                                                                                                                                                                                     
                                                                                                                                                                                                                                                                                                                              
  Assert failure(PID 3341648 [0x0032fd50], Thread: 3341648 [0x32fd50]): Assertion failed 'vnStore->VNFuncArity(func) == 1' in 'JIT.HardwareIntrinsics.Arm._Sve.SveGatherVectorVectorBasesTest__Sve_GatherVectorFirstFaulting_Bases_double_ulong:RunBasicScenario_UnsafeRead():this' during 'Do value numbering' (IL size 110;   hash 0x04f13b09; FullOpts)                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                              
      File: /home/mikabl01/dotnet/runtime/src/coreclr/jit/valuenum.cpp:12998                                                                                                                                                                                                                                                  
      Image: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun   

Seems likely, sorry about that. How do I run those tests?

[jakobbotsch]

Although, the failing test was presumably added in #105595, so it might be an unlucky conflict with this PR (this PR went in shortly before that one).

[SwapnilGaikwad]

Hi @jakobbotsch , the same issue is also observed for other intrinsics. I checked the Multiply, AddSaturate, SubtractSaturate.
You can run tests for the above intrinsics using the following steps.

1. Build the tests - ./src/tests/build.sh checked -test:JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro.csproj (Windows equivalent of the command)
2. Run the tests -

DOTNET_TieredCompilation=0 $CORE_ROOT/corerun ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll Sve_Multiply

Here, CORE_ROOT=artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root