Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exposed module object from DomainAssembly to Module #105901

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 2, 2024

DomainAssembly currently has the exposed object corresponding to its Module and Module gets it from its DomainAssembly - move it to be stored Module instead.

Module::LoadModule was returning DomainAssembly and the common thing callers immediately did was get its Module - make it return the Module instead.

Contributes to #104590

cc @jkotas @AaronRobinsonMSFT

Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

src/coreclr/vm/ceeload.cpp Outdated Show resolved Hide resolved
@elinor-fung elinor-fung merged commit 85c1a73 into dotnet:main Aug 5, 2024
90 checks passed
@elinor-fung elinor-fung deleted the module-exposed-object branch August 5, 2024 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants