-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some NRT on StringCollection #106116
Fix some NRT on StringCollection #106116
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-collections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable based on the other APIs present in the collection. @stephentoub any objections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct and we should take it. Just note that it could introduce more warnings into a consumer.
How so? It's only input parameters and none of the changed methods are virtual. |
I was thinking this would warn: |
Thanks |
Co-authored-by: Eirik Tsarpalis <[email protected]>
Co-authored-by: Eirik Tsarpalis <[email protected]>
StringCollection
can containnull
values. Fix annotations forAddRange
andCopyTo
to align with this.