Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable more_tailcalls under GCStress #106287

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

jakobbotsch
Copy link
Member

Fix #99410

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 12, 2024
@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib. Looks like this test is passing under GC stress now -- perhaps, as @SingleAccretion suggested, the original issue was around the placement of the bulk write barrier. If so that was likely fixed by #103301.

@JulieLeeMSFT
Copy link
Member

@AndyAyersMS, please review this PR before RC1 snap, 8/14.

@jakobbotsch jakobbotsch merged commit 5cd69e4 into dotnet:main Aug 14, 2024
84 of 86 checks passed
@jakobbotsch jakobbotsch deleted the fix-99410 branch August 14, 2024 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: JIT/Directed/tailcall/more_tailcalls/more_tailcalls.cmd
3 participants