-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helper Method Frames from debugdebugger #107058
Merged
AaronRobinsonMSFT
merged 5 commits into
dotnet:main
from
AaronRobinsonMSFT:hmf_x86_debug
Aug 29, 2024
Merged
Remove Helper Method Frames from debugdebugger #107058
AaronRobinsonMSFT
merged 5 commits into
dotnet:main
from
AaronRobinsonMSFT:hmf_x86_debug
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @mangod9 |
This was referenced Aug 28, 2024
jkotas
reviewed
Aug 28, 2024
@dotnet/dotnet-diag and @jkotas All green. |
jkotas
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* Remove unused AllocObjectWrapper helper for x86. * Convert Debugger.Break() * Convert Debugger.CustomNotification() * Convert StackTrace.GetStackFramesInternal()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit contains a single functions from the diagnostic space. This PR is best reviewed by each commit.
Removed unused JIT Helper for x86.
Ran diagnostics tests and confirmed no failures.