Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Backport Azure Linux test changes #107061

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Aug 27, 2024

Backport of #106554, #106698, #106835, #107119, and #106330 to release/8.0-staging

/cc @bartonjs @jeffhandley @richlander

Customer Impact

  • Customer reported
  • Found internally

These are test-only changes to react to Azure Linux 3.0. Azure Linux 3.0 disables certain cryptographic algorithms that we have unit tests for. This pull request disables those tests when run on Azure Linux.

Regression

  • Yes
  • No

Testing

This adds Azure Linux 3.0 to our CI pipeline and fixes a test that fails on Azure Linux.

This is a test-only changes to react to Azure Linux 3.0. Azure Linux 3.0 disables certain cryptographic algorithms that we have unit tests for. This pull request changes a test from using one of the disabled algorithms.

Risk

None. Test only changes.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

bartonjs
bartonjs previously approved these changes Aug 27, 2024
@bartonjs bartonjs added the Servicing-consider Issue for next servicing release review label Aug 27, 2024
@vcsjones vcsjones marked this pull request as draft August 28, 2024 23:55
@vcsjones
Copy link
Member Author

We need to add #106489 to this pull request. Will add it when it is approved there.

@vcsjones
Copy link
Member Author

@bartonjs I added #107119 to this backport. Since this PR has changed and it is a backport, I removed your previous review.

@vcsjones vcsjones marked this pull request as ready for review August 29, 2024 02:12
@vcsjones
Copy link
Member Author

/azp run runtime-extra-platforms

@vcsjones
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.10 Aug 29, 2024
@rbhanda rbhanda removed the Servicing-consider Issue for next servicing release review label Aug 29, 2024
@rbhanda rbhanda added the Servicing-approved Approved for servicing release label Aug 29, 2024
@carlossanlop
Copy link
Member

Is this ready to merge? There were CI failures.

@vcsjones
Copy link
Member Author

vcsjones commented Sep 4, 2024

All of the failures look unrelated to the change or helix timeouts. I restarted the failed legs to see if we can get a greener result.

@vcsjones
Copy link
Member Author

vcsjones commented Sep 5, 2024

The runtime leg is green. runtime-extra-platforms failed, but none of them appear to be related to this backport PR. @bartonjs does my interpretation match yours?

@carlossanlop
Copy link
Member

Friendly reminder that Code Complete for the October Release is September 9. If we want this fix to be included in that release, please merge this PR before that date.

@bartonjs
Copy link
Member

bartonjs commented Sep 5, 2024

/ba-g None of the failing status is relevant

@bartonjs bartonjs merged commit a99b483 into dotnet:release/8.0-staging Sep 5, 2024
166 of 183 checks passed
@vcsjones vcsjones deleted the backport-azl-fixes-to-release-8.0 branch September 5, 2024 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants