Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert stream override checks to QCall #107117

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Convert stream override checks to QCall #107117

merged 4 commits into from
Aug 29, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Aug 28, 2024 •
edited
Loading

Convert stream override checks to QCall and reduce the check frequency.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Aug 28, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Convert stream override checks to QCalls Convert stream override checks to QCall Aug 28, 2024
This was referenced Aug 29, 2024
Open
Closed
Open
Open
Closed
jkotas
jkotas approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

This was referenced Aug 29, 2024
Open
Open
Open
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 80187a3 into dotnet:main Aug 29, 2024
145 of 150 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the hmf_stream_override_checks branch August 29, 2024 16:38
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@AaronRobinsonMSFT @jtschuster
Convert stream override checks to QCall (dotnet#107117)
982c70b 
* Convert stream override checks to QCalls and reduce
the check frequency.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-VM-coreclr
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronRobinsonMSFT @jkotas