Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActiveIssue for resolved issues in Vector tests #107127

Merged
merged 1 commit into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ static GenericVectorTests()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/81785", TestPlatforms.Browser)]
public unsafe void IsHardwareAcceleratedTest()
{
MethodInfo methodInfo = typeof(Vector).GetMethod("get_IsHardwareAccelerated");
Expand Down Expand Up @@ -1094,10 +1093,8 @@ private void TestToString<T>(string format, IFormatProvider provider) where T :
[Fact]
public void AdditionInt64() { TestAddition<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void AdditionSingle() { TestAddition<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void AdditionDouble() { TestAddition<double>(); }
private void TestAddition<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -1161,10 +1158,8 @@ private void TestAdditionOverflow<T>() where T : struct, INumber<T>
[Fact]
public void SubtractionInt64() { TestSubtraction<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void SubtractionSingle() { TestSubtraction<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void SubtractionDouble() { TestSubtraction<double>(); }
private void TestSubtraction<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -1228,10 +1223,8 @@ private void TestSubtractionOverflow<T>() where T : struct, INumber<T>
[Fact]
public void MultiplicationInt64() { TestMultiplication<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MultiplicationSingle() { TestMultiplication<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MultiplicationDouble() { TestMultiplication<double>(); }
private void TestMultiplication<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -1272,11 +1265,9 @@ private void TestMultiplication<T>() where T : struct, INumber<T>
[ActiveIssue("https://github.com/dotnet/runtime/issues/67893", TestPlatforms.tvOS)]
public void MultiplicationWithScalarInt64() { TestMultiplicationWithScalar<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67893", TestPlatforms.tvOS)]
public void MultiplicationWithScalarSingle() { TestMultiplicationWithScalar<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67893", TestPlatforms.tvOS)]
public void MultiplicationWithScalarDouble() { TestMultiplicationWithScalar<double>(); }
private void TestMultiplicationWithScalar<T>() where T : struct, INumber<T>
Expand Down Expand Up @@ -1318,10 +1309,8 @@ private void TestMultiplicationWithScalar<T>() where T : struct, INumber<T>
[Fact]
public void DivisionInt64() { TestDivision<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DivisionSingle() { TestDivision<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DivisionDouble() { TestDivision<double>(); }
private void TestDivision<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -1388,11 +1377,9 @@ private void TestDivisionByZeroException<T>() where T : struct
public void DivisionWithScalarInt64() { TestDivisionWithScalar<long>(); }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DivisionWithScalarSingle() { TestDivisionWithScalar<float>(); }

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DivisionWithScalarDouble() { TestDivisionWithScalar<double>(); }

private void TestDivisionWithScalar<T>() where T : struct, INumber<T>
Expand Down Expand Up @@ -1460,10 +1447,8 @@ private void TestDivisionWithScalarByZeroException<T>() where T : struct, INumbe
[Fact]
public void UnaryMinusInt64() { TestUnaryMinus<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void UnaryMinusSingle() { TestUnaryMinus<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void UnaryMinusDouble() { TestUnaryMinus<double>(); }
private void TestUnaryMinus<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -1850,10 +1835,8 @@ private void TestShiftRightLogical<T>() where T : unmanaged, IBinaryInteger<T>
[Fact]
public void VectorGreaterThanInt64() { TestVectorGreaterThan<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void VectorGreaterThanSingle() { TestVectorGreaterThan<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void VectorGreaterThanDouble() { TestVectorGreaterThan<double>(); }
private void TestVectorGreaterThan<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -1889,10 +1872,8 @@ private void TestVectorGreaterThan<T>() where T : struct, INumber<T>
[Fact]
public void GreaterThanOrEqualInt64() { TestVectorGreaterThanOrEqual<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void GreaterThanOrEqualSingle() { TestVectorGreaterThanOrEqual<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void GreaterThanOrEqualDouble() { TestVectorGreaterThanOrEqual<double>(); }
private void TestVectorGreaterThanOrEqual<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2144,10 +2125,8 @@ private void TestVectorGreaterThanOrEqualAll<T>() where T : struct
[Fact]
public void LessThanInt64() { TestVectorLessThan<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void LessThanSingle() { TestVectorLessThan<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void LessThanDouble() { TestVectorLessThan<double>(); }
private void TestVectorLessThan<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2183,10 +2162,8 @@ private void TestVectorLessThan<T>() where T : struct, INumber<T>
[Fact]
public void LessThanOrEqualInt64() { TestVectorLessThanOrEqual<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void LessThanOrEqualSingle() { TestVectorLessThanOrEqual<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void LessThanOrEqualDouble() { TestVectorLessThanOrEqual<double>(); }
private void TestVectorLessThanOrEqual<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2222,10 +2199,8 @@ private void TestVectorLessThanOrEqual<T>() where T : struct, INumber<T>
[Fact]
public void LessThanAnyInt64() { TestVectorLessThanAny<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void LessThanAnySingle() { TestVectorLessThanAny<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void LessThanAnyDouble() { TestVectorLessThanAny<double>(); }
private void TestVectorLessThanAny<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2550,10 +2525,8 @@ private void TestVectorEqualsAll<T>() where T : struct, INumber<T>
[Fact]
public void ConditionalSelectInt64() { TestConditionalSelect<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void ConditionalSelectSingle() { TestConditionalSelect<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void ConditionalSelectDouble() { TestConditionalSelect<double>(); }
private void TestConditionalSelect<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2604,10 +2577,8 @@ private void TestConditionalSelect<T>() where T : struct, INumber<T>
[Fact]
public void DotProductInt64() { TestDotProduct<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DotProductSingle() { TestDotProduct<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DotProductDouble() { TestDotProduct<double>(); }
private void TestDotProduct<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2642,10 +2613,8 @@ private void TestDotProduct<T>() where T : struct, INumber<T>
[Fact]
public void MaxInt64() { TestMax<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MaxSingle() { TestMax<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MaxDouble() { TestMax<double>(); }
private void TestMax<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2680,10 +2649,8 @@ private void TestMax<T>() where T : struct, INumber<T>
[Fact]
public void MinInt64() { TestMin<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MinSingle() { TestMin<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MinDouble() { TestMin<double>(); }
private void TestMin<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2718,10 +2685,8 @@ private void TestMin<T>() where T : struct, INumber<T>
[Fact]
public void SquareRootInt64() { TestSquareRoot<long>(-1); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void SquareRootSingle() { TestSquareRoot<float>(6); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void SquareRootDouble() { TestSquareRoot<double>(15); }
private void TestSquareRoot<T>(int precision = -1) where T : struct, INumber<T>, IEquatable<T>
{
Expand Down Expand Up @@ -2814,10 +2779,8 @@ public void FloorDouble()
[Fact]
public void AbsInt64() { TestAbs<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void AbsSingle() { TestAbs<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void AbsDouble() { TestAbs<double>(); }
private void TestAbs<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2854,10 +2817,8 @@ private void TestAbs<T>() where T : struct, INumber<T>
[Fact]
public void MultiplicationReflectionInt64() { TestMultiplicationReflection<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MultiplicationReflectionSingle() { TestMultiplicationReflection<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void MultiplicationReflectionDouble() { TestMultiplicationReflection<double>(); }
private void TestMultiplicationReflection<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2893,10 +2854,8 @@ private void TestMultiplicationReflection<T>() where T : struct, INumber<T>
[Fact]
public void AdditionReflectionInt64() { TestAdditionReflection<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void AdditionReflectionSingle() { TestAdditionReflection<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void AdditionReflectionDouble() { TestAdditionReflection<double>(); }
private void TestAdditionReflection<T>() where T : struct, INumber<T>
{
Expand Down Expand Up @@ -2932,10 +2891,8 @@ private void TestAdditionReflection<T>() where T : struct, INumber<T>
[Fact]
public void DivisionReflectionInt64() { TestDivisionReflection<long>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DivisionReflectionSingle() { TestDivisionReflection<float>(); }
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60347", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsX86Process))]
public void DivisionReflectionDouble() { TestDivisionReflection<double>(); }
private void TestDivisionReflection<T>() where T : struct, INumber<T>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ internal static void AssertEqual(Vector128<double> expected, Vector128<double> a

[Fact]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicProperties, typeof(Vector128))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/81785", TestPlatforms.Browser)]
public unsafe void Vector128IsHardwareAcceleratedTest()
{
MethodInfo methodInfo = typeof(Vector128).GetMethod("get_IsHardwareAccelerated");
Expand Down