Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] ComponentModel threading fixes #107354

Conversation

steveharter
Copy link
Member

@steveharter steveharter commented Sep 4, 2024

Backport of #104407 and #103835 to release/6.0.

See also #107353 for the 8.0 port.

Customer Impact

Fixes various threading issues with TypeDescriptor and PropertyDescriptor.

Regression

Yes; a previous servicing fix caused concurrency issues with:

Testing

The 9.0 tests that were added are ported here.

Risk

Low; the fixes have been in 9.0 for several months with no reported regressions.

@steveharter steveharter added this to the 6.0.x milestone Sep 4, 2024
@steveharter steveharter self-assigned this Sep 4, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

@steveharter
Copy link
Member Author

steveharter commented Sep 4, 2024

/ba-g CI test failures appear unrelated:

x86 Release Libraries_NET48
Git fetch failed with exit code: 128
Publishing build artifacts failed with an error: Not found PathtoPublish: D:\a_work\1\s\artifacts\log\

Linux
Work item System.IO.Net5Compat.Tests
Work item System.IO.Tests

Browser wasm Release
Work item Common.Tests
Work item IcuAppLocal.Tests
Work item Invariant.Tests
Work item Microsoft.Bcl.AsyncInterfaces.Tests
Work item Microsoft.CSharp.Tests

@steveharter steveharter added the Servicing-consider Issue for next servicing release review label Sep 4, 2024
@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.35 Sep 5, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 5, 2024
@carlossanlop
Copy link
Member

Friendly reminder that Code Complete for the October Release is September 9. If we want this fix to be included in that release, please merge this PR before that date.

@carlossanlop
Copy link
Member

There were many unknown/new failures in this PR. are any of them known? Maybe re-run could clean them up?

@steveharter
Copy link
Member Author

There were many unknown/new failures in this PR. are any of them known? Maybe re-run could clean them up?

A re-run didn't help. The bulk are linux. Also, this other PR has more or less the same failures: #106220

@steveharter
Copy link
Member Author

/ba-g CI test failures appear unrelated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants