-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build NativeAOT-iOS runtime tests as standalone to restore test runs #107366
Conversation
/azp run runtime-ioslike, runtime-ioslikesimulator |
Azure Pipelines successfully started running 2 pipeline(s). |
CI shows the correct tests running again for the NativeAOT legs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix.
fyi: @ivanpovazan @kotlarmilos
Hey @jkoritzinsky thanks for fixing this quickly! One thing that is missing, is doing the same for runtime/eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml Lines 114 to 116 in 88f9aba
and here: runtime/eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml Lines 151 to 153 in 88f9aba
should do the trick. Failure for reference (from the original failing build): https://dev.azure.com/dnceng-public/public/_build/results?buildId=793084&view=logs&j=c49026c0-42bb-519d-cdde-df21b0e596aa&t=246f45a3-de00-568c-c61c-f424913337a0&l=26 |
I'll make sure to do the maccatalyst jobs as well before merging today. Thanks for the heads up! |
/azp run runtime-ioslike, runtime-ioslikesimulator, runtime-maccatalyst |
Azure Pipelines successfully started running 3 pipeline(s). |
/ba-g failures are expected |
Fixes Issue #107346
cc: @matouskozak