Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Set unwind table kind #107462

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

radekdoulik
Copy link
Member

To stop hitting assert in the verbose output, when aot compiler is built with the debug configuration of llvm

To stop hitting assert in the verbose output, when aot compiler is built
with the debug configuration of llvm
Copy link
Contributor

Tagging subscribers to this area: @lambdageek, @steveisok
See info in area-owners.md if you want to be subscribed.

@lewing
Copy link
Member

lewing commented Sep 10, 2024

This appears to be failing on ios-arm64 and tvos-arm64 (it has been rerun multiple times)

@lambdageek
Copy link
Member

Maybe related https://reviews.llvm.org/D131153

@radekdoulik
Copy link
Member Author

@pavelsavara
Copy link
Member

@lewing @pavelsavara the threading tests error looks like #102762

possibly the unwind info is now different and hopefully contains more information? @pavelsavara could you take a look? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107462-merge-cd527723c6d243f5b7/WasmTestOnFirefox-MT-System.Globalization.Calendars.Tests/1/console.14d43601.log?helixlogtype=result

I think it's unrelated to this change. It would be good to open known issue.

@radekdoulik
Copy link
Member Author

Created #108394 for the unrelated failure.

@radekdoulik
Copy link
Member Author

/ba-g debug tests failures are unrelated and known issue

@radekdoulik radekdoulik merged commit 4f66989 into dotnet:main Oct 1, 2024
76 of 81 checks passed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Oct 3, 2024
* Set unwind table kind

To stop hitting assert in the verbose output, when aot compiler is built
with the debug configuration of llvm

* Set synchronous uw table kind on arm64

* Feedback
lambdageek pushed a commit to lambdageek/runtime that referenced this pull request Oct 3, 2024
* Set unwind table kind

To stop hitting assert in the verbose output, when aot compiler is built
with the debug configuration of llvm

* Set synchronous uw table kind on arm64

* Feedback
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants