Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Update dependencies from dotnet/source-build-reference-packages #107474

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 6, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: ff965893-50ad-4147-a49e-6ccff154a18d
  • Build: 20240916.2
  • Date Produced: September 16, 2024 6:24:23 PM UTC
  • Commit: 0cbbe19fd2e94912ae9ab5dd15431ee5193d398c
  • Branch: refs/heads/release/9.0

…ence-packages build 20240815.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24374.1 -> To Version 8.0.0-alpha.1.24415.1
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

…ence-packages build 20240906.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.24415.1 -> To Version 9.0.0-alpha.1.24456.1
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-codeflow for labeling automated codeflow and removed area-Infrastructure-libraries labels Sep 6, 2024
@carlossanlop
Copy link
Member

I notified @dotnet/source-build-internal earlier today that we did not have a darc subscription from source-build-reference-packages to runtime in place for release/9.0. I was told this was not expected. So I created the subscription, as I need this flow to ensure the intellisense nuget package flows without issues to runtime and to source-build.

Unforunately, enabling this new subscription uncovered these errors:

❌.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24453.1/tools/SourceBuild/AfterSourceBuild.proj(81,5): 
error : 6 new pre-builts discovered! 
Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. 
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. 

Package IDs are: 
System.Composition.8.0.0 
System.Composition.AttributedModel.8.0.0 
System.Composition.Convention.8.0.0 
System.Composition.Hosting.8.0.0 
System.Composition.Runtime.8.0.0 
System.Composition.TypedParts.8.0.0

@dotnet/area-system-composition can you please take a look at the error and fix it? I assume this has already been addressed in main since the equivalent deps flow PR for that branch is not showing this error: #107256

@carlossanlop carlossanlop added the blocked Issue/PR is blocked on something - see comments label Sep 6, 2024
@carlossanlop carlossanlop added this to the 9.0.0 milestone Sep 6, 2024
@MichaelSimons
Copy link
Member

I notified @dotnet/source-build-internal earlier today that we did not have a darc subscription from source-build-reference-packages to runtime in place for release/9.0. I was told this was not expected. So I created the subscription, as I need this flow to ensure the intellisense nuget package flows without issues to runtime and to source-build.

Unforunately, enabling this new subscription uncovered these errors:

❌.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24453.1/tools/SourceBuild/AfterSourceBuild.proj(81,5): 
error : 6 new pre-builts discovered! 
Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. 
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. 

Package IDs are: 
System.Composition.8.0.0 
System.Composition.AttributedModel.8.0.0 
System.Composition.Convention.8.0.0 
System.Composition.Hosting.8.0.0 
System.Composition.Runtime.8.0.0 
System.Composition.TypedParts.8.0.0

@dotnet/area-system-composition can you please take a look at the error and fix it? I assume this has already been addressed in main since the equivalent deps flow PR for that branch is not showing this error: #107256

These just need to be added to the prebuilt baseline. These are all instances that get "lifted" in the product source-build and are therefore allowed prebuilts at the repo level.

…ence-packages build 20240909.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24456.1 -> To Version 9.0.0-alpha.1.24459.3
…ence-packages build 20240916.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24459.3 -> To Version 9.0.0-alpha.1.24466.2
@carlossanlop
Copy link
Member

@dotnet/area-system-composition this is blocking the 9.0 branch from ingesting the source-build-reference-packages deps flows.

@MichaelSimons do you mean we need to modify some files in the runtime repo to suppress the errors? If so, which ones?

@buyaa-n
Copy link
Contributor

buyaa-n commented Sep 16, 2024

Unforunately, enabling this new subscription uncovered these errors:

❌.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24453.1/tools/SourceBuild/AfterSourceBuild.proj(81,5): 
error : 6 new pre-builts discovered! 
Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. 
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. 

Package IDs are: 
System.Composition.8.0.0 
System.Composition.AttributedModel.8.0.0 
System.Composition.Convention.8.0.0 
System.Composition.Hosting.8.0.0 
System.Composition.Runtime.8.0.0 
System.Composition.TypedParts.8.0.0

@dotnet/area-system-composition can you please take a look at the error and fix it? I assume this has already been addressed in main since the equivalent deps flow PR for that branch is not showing this error: #107256

I have never seen such error, as far as I know we did not fix anything like this in main, this more sounds like infra issue to me

@carlossanlop
Copy link
Member

@buyaa-n The deps flow subscription was recently created last week for release/9.0, which means we had not been capturing any failures from the changes that have been introduced in the last couple of months since that branch was created. Have there been any System.ComponentModel.Composition changes introduced in release/9.0 that could cause source build issues?

https://github.com/dotnet/runtime/commits/main/src/libraries/System.ComponentModel.Composition

@buyaa-n
Copy link
Contributor

buyaa-n commented Sep 16, 2024

I don't see anything that merged into 9.0 branch except #107724, but it is merged just 4 days ago

@ericstj
Copy link
Member

ericstj commented Sep 17, 2024

Looks like we need this change 094229e#diff-f88ce4026366ce74fb1a981785c542757617abf4393a33ca34465a5e9a0dd343R9

@carlossanlop
Copy link
Member

/backport to release/9.0-rc2

Copy link
Contributor

Started backporting to release/9.0-rc2: https://github.com/dotnet/runtime/actions/runs/10894241797

@carlossanlop carlossanlop merged commit b310f25 into release/9.0 Sep 17, 2024
155 of 159 checks passed
@carlossanlop carlossanlop deleted the darc-release/9.0-92ffa4c6-b1d5-46d1-9ff1-8a8c3d2b27f4 branch September 17, 2024 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants