[release/9.0] ARM64-SVE: Allow op inside conditionalselect to be non HWintrinsic #107581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
amanasifkhalid
approved these changes
Sep 10, 2024
|
@jeffschwMSFT @JulieLeeMSFT @carlossanlop - This is ready to merge. |
|
Did this get @jeffschwMSFT 's M2 blessing? |
3 tasks
|
CC @jeffschwMSFT. |
jeffschwMSFT
approved these changes
Sep 11, 2024
jeffschwMSFT
added
Servicing-approved
2 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107180 to release/9.0
/cc @kunalspathak @a74nh
Customer Impact
When we lower
ConditionalSelectnodes nested inside aConditionalSelect, we always assumed that they are created by the embedded mask operation (a term that is introduced by SVE). This led to assert and potentially bad code gen.Regression
This was missed during the development of SVE that was written in .NET 9.
Testing
Added test case that passes and verified internally.
Risk
Low because this just impacts SVE instruction set.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.