Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0][browser] Enable the log profiler - bad branch #107626

Closed
wants to merge 1 commit into from
Closed

[release/9.0][browser] Enable the log profiler - bad branch #107626

wants to merge 1 commit into from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Sep 10, 2024 •
edited
Loading

Backport of #107434 to release/9.0

Customer Impact

  • Customer reported, customer contribution
  • Found internally

Enables Uno to use legacy memory profiler, which they already use with custom build of the runtime in Net8.
We don't have EventPipe solution for browser yet.

Regression

  • Yes
  • No

Testing

Automated test on main branch

Risk

Low. This is only used when

  • customer installed wasm workload
  • customer enabled <WasmProfilers>log;</WasmProfilers><WasmBuildNative>true</WasmBuildNative>

@pavelsavara pavelsavara added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Sep 10, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Sep 10, 2024
@pavelsavara pavelsavara mentioned this pull request Sep 10, 2024
Merged
This was referenced Sep 11, 2024
Open
Open
@lewing lewing marked this pull request as ready for review September 12, 2024 15:28
jeffschwMSFT
jeffschwMSFT approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can merge when ready

@jeffschwMSFT
Copy link
Member

@pavelsavara this is in the wrong branch. RC1 is closed and we are in the last days of RC2, please move to release/9 (approval is RC2 only)

@jeffschwMSFT jeffschwMSFT added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed Servicing-consider Issue for next servicing release review labels Sep 12, 2024
@pavelsavara pavelsavara changed the title [release/9.0][browser] Enable the log profiler [release/9.0][browser] Enable the log profiler - bad branch Sep 12, 2024
@pavelsavara
Copy link
Member Author

closing in favor of #107747

@pavelsavara pavelsavara mentioned this pull request Sep 12, 2024
Merged
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @jeffschwMSFT @ilonatommy