Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Fix the clr build error on Alpine. #107669

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[LoongArch64] Fix the clr build error on Alpine. #107669

merged 1 commit into from
Sep 11, 2024

Conversation

LuckyXu-HF
Copy link
Contributor

@LuckyXu-HF LuckyXu-HF commented Sep 11, 2024 •
edited
Loading

[LoongArch64] Fix the clr build error on Alpine.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 11, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Sep 11, 2024 •
edited
Loading

Hi @jkotas , do we have a chance to align the ./src/native/external/libunwind/src/loongarch64/getcontext.S with https://github.com/libunwind/libunwind/blob/master/src/loongarch64/getcontext.S ?
Because the endina.h is useless in getcontext.S for LA64.
Could you please give us some suggestions? Thank you very much.

@jkotas
Copy link
Member

jkotas commented Sep 11, 2024

Add note "Apply libunwind/libunwind#741" to https://github.com/dotnet/runtime/blob/main/src/native/external/libunwind-version.txt and delete the #include <endian.h>.

@LuckyXu-HF
Copy link
Contributor Author

Add note "Apply libunwind/libunwind#741" to https://github.com/dotnet/runtime/blob/main/src/native/external/libunwind-version.txt and delete the #include <endian.h>.

Ok, Thanks very much, I will do this in this PR.

@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Sep 11, 2024 •
edited
Loading

@shushanhf @jkotas Could you please review this PR? Thanks.

jkotas
jkotas approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shushanhf
shushanhf approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
Thanks!

@jkotas jkotas merged commit 102f28e into dotnet:main Sep 11, 2024
148 of 152 checks passed
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2024
Open
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch September 11, 2024 06:05
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2024
Open
3 tasks
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@LuckyXu-HF @jtschuster
[LoongArch64] Fix the clr build error on Alpine. (dotnet#107669)
05cbb1a 
* Apply libunwind: libunwind/libunwind#741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

@shushanhf shushanhf shushanhf approved these changes

@janvorli janvorli Awaiting requested review from janvorli janvorli is a code owner

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT AaronRobinsonMSFT is a code owner

Assignees
No one assigned
Labels
arch-loongarch64 area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuckyXu-HF @jkotas @shushanhf