Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit dependency on System.Buffers from System.Formats.Asn1 #107679

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Rob-Hague
Copy link
Contributor

System.Formats.Asn1 depends on System.Memory >=4.5.5 and System.Buffers >=4.5.1, but System.Memory 4.5.5 already depends on System.Buffers >=4.5.1, so the explicit dependency should not be needed, right...?

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 11, 2024
@am11 am11 added area-System.Formats.Asn1 and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 21, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-formats-asn1, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @Rob-Hague !

@adamsitnik
Copy link
Member

/ba-g unrelated

@adamsitnik adamsitnik merged commit a8d1fc1 into dotnet:main Sep 24, 2024
83 of 85 checks passed
@Rob-Hague Rob-Hague deleted the asn1 branch September 24, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Formats.Asn1 community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants