-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: use explicit cast away GC when passing byref to unmanaged callees #107811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise the fix done in dotnet#39105 to make the cast from byref to native int via an explicit cast, rather than retyping the node. Fixes dotnet#107045.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 13, 2024
@EgorBo PTAL Two diffs expected (in Tier0 code). This IL comes from C++/CLI in wpf, so not planning on adding a test case. |
EgorBo
approved these changes
Sep 13, 2024
3 tasks
ILC failing with
Seems like it is unrelated... possibly #104340? |
The other failure is similar (but maybe not the same) as #103525
|
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
dotnet#107811) Revise the fix done in dotnet#39105 to make the cast from byref to native int via an explicit cast, rather than retyping the node. Fixes dotnet#107045.
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
dotnet#107811) Revise the fix done in dotnet#39105 to make the cast from byref to native int via an explicit cast, rather than retyping the node. Fixes dotnet#107045.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the fix done in #39105 to make the cast from byref to native int via an explicit cast, rather than retyping the node.
Fixes #107045.