JIT: refactor AddCodeDsc #108095
Merged
JIT: refactor AddCodeDsc #108095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main aim of this change is to remove the block reference from AddCodeDsc, as it can become stale over time, making it impossible to determine where a throw helper block should be placed, if we have subsequently eliminated EH regions. Instead we use the try/handler indices plus a bit of extra info to track where the throw helper block should be placed. I also moved the key formation logic nearby and reworked it a bit, and gave the AddCodeDscs debug indices for dumps. This should unblock doing late EH region removal.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@BruceForstall PTAL Small diffs expected, because the throw blocks get placed differently (there is now no "nearby" hint). |
|
@BruceForstall ping |
BruceForstall
approved these changes
Sep 27, 2024
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
The main aim of this change is to remove the block reference from AddCodeDsc, as it can become stale over time, making it impossible to determine where a throw helper block should be placed, if we have subsequently eliminated EH regions. Instead we use the try/handler indices plus a bit of extra info to track where the throw helper block should be placed. I also moved the key formation logic nearby and reworked it a bit, and gave the AddCodeDscs debug indices for dumps. This should unblock doing late EH region removal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim of this change is to remove the block reference from AddCodeDsc, as it can become stale over time, making it impossible to determine where a throw helper block should be placed, if we have subsequently eliminated EH regions.
Instead we use the try/handler indices plus a bit of extra info to track where the throw helper block should be placed.
I also moved the key formation logic nearby and reworked it a bit, and gave the AddCodeDscs debug indices for dumps.
This should unblock doing late EH region removal.