Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid lock contention during thread creation of thread pool #108135

Merged

Conversation

AlanLiu90
Copy link
Contributor

For a worker thread, Thread.StartCore and Thread.SetThreadPoolWorkerThreadName have lock contention.

Fix #108057

For a worker thread, Thread.StartCore and Thread.SetThreadPoolWorkerThreadName have lock contention.

Fix dotnet#108057
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 23, 2024
@AlanLiu90
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kouvel kouvel merged commit 65061ad into dotnet:main Sep 23, 2024
143 of 148 checks passed
kouvel added a commit to kouvel/runtime that referenced this pull request Sep 23, 2024
Followup to dotnet#108135. The test seems to be failing occasionally, it doesn't seem to be reliable, as other components that are involved can contend on locks aside from lock contention the test is looking for.
kouvel added a commit that referenced this pull request Sep 24, 2024
Followup to #108135. The test seems to be failing occasionally, it doesn't seem to be reliable, as other components that are involved can contend on locks aside from lock contention the test is looking for.
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
…08135)

For a worker thread, Thread.StartCore and Thread.SetThreadPoolWorkerThreadName have lock contention.

Fix dotnet#108057
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
Followup to dotnet#108135. The test seems to be failing occasionally, it doesn't seem to be reliable, as other components that are involved can contend on locks aside from lock contention the test is looking for.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Threading community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to .net 6 causes higher lock contention
2 participants