Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Fix createdump 'stack smashing detected' error on arm64 #108208

Open
wants to merge 1 commit into
base: release/9.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 24, 2024

Backport of #108166 to release/9.0

/cc @mikem8361

Customer Impact

  • Customer reported
  • Found internally

Customers (in this case RHEL dev) can not create core dumps on linux arm64 platforms.

This change restores the fix from PR #91865 by changing the size back to SpecialDiagInfoSize but uses the 4 parameter MemoryRegion constructor that doesn't assert the address/size is on a PAGE_SIZE alignment (PR #95433).

Issue: #108023

Regression

  • Yes
  • No

The changes from PR #91865 were reverted by PR #95433.

Testing

The dev that reported the issue has verified this fix.

Risk

Low. Restoring original working code.

The changes from PR #91865 were reverted by PR #95433.

This change restores the fix from PR #91865 by changing the size back to SpecialDiagInfoSize
but uses the 4 parameter MemoryRegion constructor that doesn't assert the address/size is on
a PAGE_SIZE alignment (PR #95433).

Issue: #108023
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@mikem8361 mikem8361 self-assigned this Sep 24, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in GA

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Sep 24, 2024
@jeffschwMSFT jeffschwMSFT added this to the 9.0.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Diagnostics-coreclr Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants