[release/8.0-staging] [aot] mono_aot_split_options: reset state after a backslash #108213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lambdageek and
SamMonoRT
as code owners
lambdageek
requested review from
steveisok
and removed request for
SamMonoRT
jeffschwMSFT
removed
the
Servicing-consider
|
@jeffschwMSFT usually you leave a comment when you twiddle the labels. Did we decide this is not going to meet the bar for 8.0 or did you forget to add the "servicing-approved" label? |
|
we discussed in teams. we will take this for 9 GA. without a customer it does not directly reach the bar |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108067 to release/8.0-staging
/cc @lambdageek
Customer Impact
Customers targeting WebAssembly, Android or iOS with projects in a directory containing a
"may run into crashes or errors during AOT compilation.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manual testing
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.