-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MonoClass:inlinearray_value out of MonoClass #109363
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
Thanks for the contribution @syfFerdinand ! |
/cc @steveisok |
…into fix/move-inlinearray-value
…alue for PROP_INLINEARRAY_VALUE
@kg can you please give this a review? |
Is it normal for this to change the MonoAOTOffsets? I assume because a field was removed from MonoClass? |
yea that's the most likely reason |
If nobody else gets to it I will try to fix the offsets this week |
Hi @kg and @lambdageek, I'll be working on updating the MonoAOTOffsets. Should I just remove the line DECL_OFFSET2(MonoClass,inlinearray_value,128) from MonoAOTOffsets, or is there something more specific I need to do? Thanks for your guidance! |
Can you see https://dev.azure.com/dnceng-public/public/_build/results?buildId=865527&view=artifacts&pathAsName=false&type=publishedArtifacts ? I believe there are downloads for the offsets there, which might be what you need. |
Note #109612 added the actual offset files. Any updates should go into these. |
Summary
This PR addresses issue #103913 by moving the inlinearray_value property from MonoClass to the infrequent_data structure. This change aims to optimize memory usage by storing rarely used properties in a less frequently accessed structure.
Details
inlinearray_value
fromMonoClass
toMonoPropertyBag
within theinfrequent_data
structure.inlinearray_value
access to use the new structure.Related Issue
Fixes #103913