Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UTF-8 in PemEncoding #109438

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Add support for UTF-8 in PemEncoding #109438

merged 5 commits into from
Nov 5, 2024

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Nov 1, 2024

This extends PemEncoding to support UTF-8.

Closes #99614

@vcsjones vcsjones self-assigned this Nov 1, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@build-analysis build-analysis bot mentioned this pull request Nov 1, 2024
Open
This was referenced Nov 5, 2024
Open
Open
This was referenced Nov 5, 2024
Open
Open
Open
@vcsjones vcsjones merged commit a757537 into dotnet:main Nov 5, 2024
83 checks passed
@vcsjones vcsjones deleted the utf8-pem-encoding2 branch November 5, 2024 18:39
@vcsjones vcsjones added this to the 10.0.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@bartonjs bartonjs bartonjs approved these changes

Assignees

@vcsjones vcsjones

Labels
area-System.Security new-api-needs-documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: PemEncoding for UTF8
3 participants
@vcsjones @stephentoub @bartonjs