[release/9.0-staging] Upgrade our macOS build machines to the latest non-beta x64 image #109455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
needs-area-label
github-actions
bot
force-pushed
the
backport/pr-109454-to-release/9.0-staging
branch
from
e9ef4b6
to
5f65b3c
Compare
hoyosjs
approved these changes
Nov 1, 2024
akoeplinger
reviewed
Nov 4, 2024
| @@ -170,7 +170,7 @@ jobs: | |||
|
|
|||
| # OSX Public Build Pool (we don't have on-prem OSX BuildPool). | |||
| ${{ if and(in(parameters.osGroup, 'osx', 'maccatalyst', 'ios', 'iossimulator', 'tvos', 'tvossimulator'), eq(variables['System.TeamProject'], 'public')) }}: | |||
| vmImage: 'macos-12' | |||
| vmImage: 'macos-13' | |||
There was a problem hiding this comment.
I think we'll need to bump the official build image too since I see the same deprecation warning in the official build
There was a problem hiding this comment.
I'll run a test official build for this branch and the 8.0 one to make sure nothing breaks.
There was a problem hiding this comment.
Official builds look good. Merging
jeffschwMSFT
approved these changes
Nov 4, 2024
|
/ba-g browser timeout unrelated |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109454 to release/9.0-staging
/cc @jkoritzinsky
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
The macOS-12 build pools are going away in December, so we need to switch away from them before they are removed to avoid failures in public CI.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
CI validation of building on the new build pools.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low: This PR validates that the build continues to work. Additionally, we selected an x64 macOS pool to limit possible churn.