Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trimmer attributes for ComActivator #109655

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

Also removed unnecessary logging.

Related to dotnet/sdk#44751.

/cc @sbomer

Copy link
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@sbomer
Copy link
Member

sbomer commented Nov 8, 2024

I see that we also do a lookup for other COM attributes in GetDataForComInvocation and GenerateProgIdForType - I think those should be annotated as well, to avoid IL2045 warnings for the following program:

using System.Runtime.InteropServices;

Marshal.GenerateProgIdForType(null);
new ComAwareEventInfo(null, null).AddEventHandler(null, null);

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@akoeplinger
Copy link
Member

/ba-g timeouts are unrelated to the changes.

@akoeplinger
Copy link
Member

Merging to unblock sdk flow.

@akoeplinger akoeplinger merged commit 19cd424 into dotnet:main Nov 9, 2024
151 of 155 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the update_annotations branch November 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants