-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SDK from bootstrapped CLI rather than testhost #136
Conversation
Port dotnet/corefx@dd2ad43 This also removes copying the SDK to the testhost directory since that is no longer needed.
We should log the test failures before merging. |
This PR looks interesting. :) Will it make it easier to run any random .NET Core app I have where I run it with 'dotnet run' and use my privately built .NET Core runtime instead of the globally installed one? Currently, when I want to run an existing app against my 'master' built .NET Core, I have to manually copy/change files into the existing |
This PR is just restoring the behavior we had in CoreFx that enables Visual Studio's test explorer to activate the shared framework we create under
@davidsh You should be able to use the shared framework we stage as part of the build for testing. Check under |
FileSystemWatcher failure on mac is https://github.com/dotnet/corefx/issues/38966. I added a pointer to the issue. Crossgen failure looks like a problem with that test. It's not failing and not reporting any results. @ViktorHofer do you know what the deal is with that? |
@jashook is currently investigating that failure. |
In that case will merge as failures are understood |
Port dotnet/corefx@dd2ad43
This also removes copying the SDK to the testhost directory
since that is no longer needed.