Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SDK from bootstrapped CLI rather than testhost #136

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Use SDK from bootstrapped CLI rather than testhost #136

merged 1 commit into from
Nov 20, 2019

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Nov 19, 2019

Port dotnet/corefx@dd2ad43

This also removes copying the SDK to the testhost directory
since that is no longer needed.

Port dotnet/corefx@dd2ad43

This also removes copying the SDK to the testhost directory
since that is no longer needed.
@ViktorHofer
Copy link
Member

We should log the test failures before merging.

@davidsh
Copy link
Contributor

davidsh commented Nov 20, 2019

This PR looks interesting. :)

Will it make it easier to run any random .NET Core app I have where I run it with 'dotnet run' and use my privately built .NET Core runtime instead of the globally installed one?

Currently, when I want to run an existing app against my 'master' built .NET Core, I have to manually copy/change files into the existing /usr/share/dotnet/shared/Microsoft.NETCore.App/3.0 folder (or Windows equivalent).

@ericstj
Copy link
Member Author

ericstj commented Nov 20, 2019

This PR is just restoring the behavior we had in CoreFx that enables Visual Studio's test explorer to activate the shared framework we create under artifacts\bin\testhost.

when I want to run an existing app against my 'master' built .NET Core, I have to manually copy/change files

@davidsh You should be able to use the shared framework we stage as part of the build for testing. Check under artifacts\bin\testhost. If you use this dotnet.exe to start your app, and you set the DOTNET_MULTILEVEL_LOOKUP=0 it will force it to run against that shared framework. If you have an app with an Exe (or COM component) that you'd like to use this shared framework you'll also need to set DOTNET_ROOT, since those cannot base their probing off the location of dotnet.exe.

@ericstj
Copy link
Member Author

ericstj commented Nov 20, 2019

FileSystemWatcher failure on mac is https://github.com/dotnet/corefx/issues/38966. I added a pointer to the issue.

Crossgen failure looks like a problem with that test. It's not failing and not reporting any results. @ViktorHofer do you know what the deal is with that?

@safern
Copy link
Member

safern commented Nov 20, 2019

Crossgen failure looks like a problem with that test. It's not failing and not reporting any results. @ViktorHofer do you know what the deal is with that?

@jashook is currently investigating that failure.

@ericstj
Copy link
Member Author

ericstj commented Nov 20, 2019

In that case will merge as failures are understood

@ericstj ericstj merged commit 7e1d054 into dotnet:master Nov 20, 2019
@ViktorHofer ViktorHofer deleted the ericstj-buildVSbootstrapCLI branch November 20, 2019 22:38
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants