Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete System.Data.SqlClient package #2275

Merged
merged 7 commits into from
Feb 5, 2020
Merged

Delete System.Data.SqlClient package #2275

merged 7 commits into from
Feb 5, 2020

Commits on Feb 5, 2020

  1. Delete System.Data.SqlClient package 

    Fixes https://github.com/dotnet/corefx/issues/40846
    @jkotas
    jkotas committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    b201592 View commit details
    Browse the repository at this point in the history

  2. Delete unnecessary SqlClient references

    @jkotas
    jkotas committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    8724e08 View commit details
    Browse the repository at this point in the history

  3. Unify System.Data.SqlClient package reference

    @jkotas
    jkotas committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    0cc1f57 View commit details
    Browse the repository at this point in the history

  4. Add System.Data facade test

    @jkotas
    jkotas committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    1caf492 View commit details
    Browse the repository at this point in the history

  5. Add System.Data.SqlClient references 

    - Add System.Data.SqlClient package references for tests that need it
- Use System.Data.SqlClient reference assembly to build the System.Data shim
- Disable ILLinker for the shims since it does not work well with incremental builds and it is not necessary anyway

Try to use package references in tests
    @jkotas
    jkotas committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    641229e View commit details
    Browse the repository at this point in the history

  6. Disable tests on Mono

    @jkotas
    jkotas committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    b225209 View commit details
    Browse the repository at this point in the history

  7. Define System.Data.SqlClient version in Versions.props

    @jkotas
    jkotas committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    d38f725 View commit details
    Browse the repository at this point in the history