Annotate System.Security.Cryptography.Algorithms for nullable #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
requested review from
stephentoub,
eiriktsarpalis,
bartonjs and
safern
bartonjs
reviewed
Jan 30, 2020
src/libraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/ECDsa.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 30, 2020
src/libraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/ECDsa.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 30, 2020
...ibraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/ECPoint.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 30, 2020
...ibraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/HMACMD5.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 30, 2020
src/libraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/RSA.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 30, 2020
...em.Security.Cryptography.Algorithms/src/System/Security/Cryptography/SignatureDescription.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
src/libraries/Common/src/Internal/Cryptography/BasicSymmetricCipherBCrypt.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Bignum.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Dsa.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
...es/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EcDsa.ImportExport.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EcKey.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
src/libraries/Common/src/Interop/Windows/BCrypt/Interop.BCryptEncryptDecrypt.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
src/libraries/Common/src/System/Security/Cryptography/ECOpenSsl.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 30, 2020
bartonjs
reviewed
Jan 30, 2020
...em.Security.Cryptography.Algorithms/src/System/Security/Cryptography/SignatureDescription.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 30, 2020
...em.Security.Cryptography.Algorithms/src/System/Security/Cryptography/SignatureDescription.cs
Outdated
Show resolved
Hide resolved
Merged
iSazonov
reviewed
Feb 3, 2020
src/libraries/Common/src/Internal/Cryptography/BasicSymmetricCipher.cs
Outdated
Show resolved
Hide resolved
|
@bartonjs @stephentoub please let me know if you have any more comments |
bartonjs
reviewed
Feb 4, 2020
...aries/System.Security.Cryptography.Algorithms/ref/System.Security.Cryptography.Algorithms.cs
Show resolved
Hide resolved
bartonjs
reviewed
Feb 4, 2020
...aries/System.Security.Cryptography.Algorithms/ref/System.Security.Cryptography.Algorithms.cs
Show resolved
Hide resolved
|
@bartonjs please let me know if you have any more comments |
bartonjs
approved these changes
Feb 11, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2339