Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Enable debugging for netcore configurations by default. #31683

Merged
merged 3 commits into from
Feb 6, 2020

Conversation

steveisok
Copy link
Member

What this means is:

  1. --debug is no longer needed since the default is TRUE
  2. --debug=ignore is a new switch to go back to the old mono default

Fixes #31662

What this means is:

1. --debug is no longer needed since the default is TRUE
2. --debug=ignore is a new switch to go back to the old mono default

Fixes dotnet#31662
@@ -1605,7 +1610,12 @@ mini_usage (void)
"\n"
"Development:\n"
" --aot[=<options>] Compiles the assembly to native code\n"
#ifdef ENABLE_NETCORE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest -nodebug.

src/mono/mono/mini/driver.c Outdated Show resolved Hide resolved
src/mono/mono/mini/driver.c Show resolved Hide resolved
@marek-safar
Copy link
Contributor

Is this really the approach we want to take? I don't see an easy way for every release build to disable this behaviour.

We could instead recognize existing COMPlus_EnableDiagnostics and convert it to full MonoVM debug mode

@lewurm
Copy link
Contributor

lewurm commented Feb 4, 2020

Is this really the approach we want to take? I don't see an easy way for every release build to disable this behaviour.

For Release the tooling can pass

  1. --debug=ignore, or
  2. Don't care, because the performance implications aren't that bad. Having useful stack traces is imho the better default behavior anyway.

@steveisok
Copy link
Member Author

steveisok commented Feb 4, 2020

@marek-safar What do we want to do? I can revert / do what you suggested. However, if there are no/limited performance implications, then my vote is to keep the PR as is.

Copy link
Contributor

@marek-safar marek-safar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vargaz confirmed the simple version of --debug is not that expensive so let's enable it by default.

@steveisok steveisok merged commit 079d448 into dotnet:master Feb 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable --debug mode in Mono by default
7 participants