-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Enable debugging for netcore configurations by default. #31683
Conversation
What this means is: 1. --debug is no longer needed since the default is TRUE 2. --debug=ignore is a new switch to go back to the old mono default Fixes dotnet#31662
@@ -1605,7 +1610,12 @@ mini_usage (void) | |||
"\n" | |||
"Development:\n" | |||
" --aot[=<options>] Compiles the assembly to native code\n" | |||
#ifdef ENABLE_NETCORE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest -nodebug.
Is this really the approach we want to take? I don't see an easy way for every release build to disable this behaviour. We could instead recognize existing |
For Release the tooling can pass
|
Additionally both XI and VSMac already unconditionally pass |
@marek-safar What do we want to do? I can revert / do what you suggested. However, if there are no/limited performance implications, then my vote is to keep the PR as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vargaz confirmed the simple version of --debug
is not that expensive so let's enable it by default.
What this means is:
Fixes #31662