Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining libraries references to string.Copy #31706

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

GrabYourPitchforks
Copy link
Member

Since string.Copy is obsolete, removing remaining code references to this method.

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -4727,7 +4727,7 @@ private static string ConvertValuesToName(string str)
bool bAdd = true;
if (str.Length == 0)
{
return string.Copy("");
return string.Empty;
Copy link
Member

@stephentoub stephentoub Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the... umm...

@jkotas
Copy link
Member

jkotas commented Feb 4, 2020

CI failure is known issue: #2176

@jkotas jkotas merged commit 3e5f870 into dotnet:master Feb 4, 2020
@GrabYourPitchforks GrabYourPitchforks deleted the string_copy branch February 4, 2020 08:38
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants