Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable crypto tests affected by libssl in OSX #31879

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Disable crypto tests affected by libssl in OSX #31879

merged 1 commit into from
Feb 6, 2020

Conversation

safern
Copy link
Member

@safern safern commented Feb 6, 2020

@safern safern mentioned this pull request Feb 6, 2020
Closed
bartonjs
bartonjs approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like us to wait until engineering says that they won't fix the problem today; just to avoid merging this then immediately rolling it back.

But I also appreciate that we're in a not great state.

@safern
Copy link
Member Author

safern commented Feb 6, 2020

I'd like us to wait until engineering says that they won't fix the problem today; just to avoid merging this then immediately rolling it back.

I agree. Will add the no-merge label in the meantime.

@safern safern added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 6, 2020
@safern
Copy link
Member Author

safern commented Feb 6, 2020

Build is green. The last response was:

We have people actively working on fixing these. We are close but there are quite a few machines to manually check and resolve.

So I'll merge, I will revert once we get notified that they are fixed. It is good to start having more green builds to avoid people merging bad changes 😄

@safern safern removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 6, 2020
@safern safern merged commit 3203ee2 into dotnet:master Feb 6, 2020
@safern safern deleted the DisableCryptoTests branch February 6, 2020 20:48
@ghost ghost added the will_lock_this label Dec 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@bartonjs bartonjs bartonjs approved these changes

Assignees
No one assigned
Labels
area-System.Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@safern @jaredpar @bartonjs @Dotnet-GitSync-Bot