Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [test-only, not for merge] Signing in PR runs + revert 31807 #32044

Closed
wants to merge 2 commits into from

Conversation

trylek
Copy link
Member

@trylek trylek commented Feb 10, 2020

This experiment will successfully complete if the PR job fails :-).

Make URCT copying unconditional to unblock installer tasks in debug
mode.

Thanks

Tomas
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a test. (For #31926)

@dagood dagood mentioned this pull request Feb 10, 2020
@trylek
Copy link
Member Author

trylek commented Feb 10, 2020

@dagood - could you please double-check that the failures in the installer jobs match your expectations when you have a chance?

@dagood
Copy link
Member

dagood commented Feb 10, 2020

Yep, perfect! Thanks.

@ViktorHofer
Copy link
Member

@trylek I think we can close this now?

@trylek
Copy link
Member Author

trylek commented Feb 11, 2020

For sure, thanks for reminding me.

@trylek trylek closed this Feb 11, 2020
@trylek trylek deleted the SigningInPRRunsAndRevert31807 branch February 11, 2020 20:48
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants